chore: Prevent users from creating txn alerts thru api #101177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shruthilayaj
commented
Oct 8, 2025
| } | ||
| mock_find_channel_id_for_alert_rule.assert_called_once_with(kwargs=kwargs) | ||
|
|
||
| def test_eap_alert_with_invalid_time_window(self) -> None: |
There was a problem hiding this comment.
just moved this test to the right class
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101177 +/- ##
===========================================
- Coverage 81.09% 81.09% -0.01%
===========================================
Files 8669 8669
Lines 384582 384607 +25
Branches 24275 24275
===========================================
+ Hits 311881 311896 +15
- Misses 72354 72364 +10
Partials 347 347 |
shruthilayaj
deleted the
shruthi/chore/prevent-users-from-creating-txn-alerts-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already prevented in the UI when the flag is enabled